[buildd-tools-devel] Bug#570807: Bug#570807: sbuild: Use of uninitialized value in unlink at /usr/bin/sbuild line 335.

[Roger Leigh]

On Sun, Feb 21, 2010 at 04:13:26PM +0100, Philipp Kern wrote:
> Package: sbuild
> 
> When running sbuild from buildd git[1] I get the following when terminating
> sbuild with a signal in batch mode:
> 
> Use of uninitialized value in unlink at /usr/bin/sbuild line 335.
> 
> The lines in question:
> 
> sub shutdown ($) {
> [...]
>   331         $jobs{$current_job}->close_build_log();
>   332         $jobs{$current_job}->set('binNMU Name', undef);
>   333     }
>   334     close_log($conf);
> >>335     unlink( $jobs{$current_job}->get('Jobs File') ) if $conf->get('BATCH_MODE');
>   336     $? = 0; $! = 0;
>   337     if ($conf->get('SBUILD_MODE') eq "user") {
>   338         exit 1;
>   339     }
>   340 
> [...]
> }
> 
> I don't know what the logic of the Jobs File should be, currently.
> It would be nice if that could be fixed by someone who does.  :)

Is this still causing you problems with the current buildd branch?
This was changed to

    close_log($conf);
    unlink($conf->get('JOB_FILE'))
	if $conf->get('BATCH_MODE');
    unlink("SBUILD-FINISHED") if $conf->get('BATCH_MODE');

Where JOB_FILE defaults to 'build-progress', or is set using $job_file,
so it should no longer be possible for it to be undefined.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20101103/1d6f8f13/attachment.pgp>