[buildd-tools-devel] Bug#607606: Bug#607606: sbuild-createchroot: broken option parser

Roger Leigh rleigh at codelibre.net
Sun Feb 13 23:31:41 UTC 2011


tags 607606 + fixed-upstream pending
merge 607606 610007
thanks

On Wed, Feb 09, 2011 at 03:55:13PM +0100, Marc Dequènes (Duck) wrote:
> --- sbuild-createchroot	2010-12-30 17:23:16.215981502 +0100
> +++ /usr/sbin/sbuild-createchroot	2011-02-08 11:25:03.128897880 +0100
> @@ -74,7 +74,6 @@
>  package Options;
>  
>  use Sbuild::OptionsBase;
> -use Sbuild::Conf;
>  
>  BEGIN {
>      use Exporter ();
> @@ -85,6 +84,17 @@
>      @EXPORT = qw();
>  }
>  
> +sub new {
> +    my $class = shift;
> +    my $conf = shift;
> +    my $program = shift;
> +    my $section = shift;
> +
> +    my $self = $class->SUPER::new($conf);
> +    bless($self, $class);
> +    return $self;
> +}
> +
>  sub set_options {
>      my $self = shift;

This was fixed in upstream git:
http://git.debian.org/?p=buildd-tools/sbuild.git;a=commitdiff;h=4f484d6ad87345c1efdd4818bcd6d60293f91e17
Note it's a bit simpler than your patch; it just makes sure nothing is
imported into the namespace that affects the options parsing.

It will be in the next upload (soon).


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20110213/a8a9d0cf/attachment-0001.pgp>


More information about the Buildd-tools-devel mailing list