[buildd-tools-devel] Bug#608659: Bug#608659: ENVIRONMENT_FILTER conf option filters out DEBIAN_FRONTEND by default

[Roger Leigh]

tags 608659 + fixed-upstream pending
thanks

On Sun, Jan 02, 2011 at 03:34:33PM +0200, Modestas Vainius wrote:
> Package: libsbuild-perl
> Version: 0.60.8-1
> Severity: important
> File: /usr/share/perl5/Sbuild/Conf.pm
> Tags: patch
> 
> Hello,
> 
> The default for ENVIRONMENT_FILTER option filters out DEBIAN_FRONTEND
> environment variable. Therefore, DEBIAN_FRONTEND=noninteractive has no effect
> whether Sbuild code itself attempts to set it or whether a user tries to export
> it in ~/.sbuildrc.
> 
> Obviously, the bug has very bad side effects for unattended builds as it may
> cause them to hang while waiting for input from debconf (e.g. samba-common).
> On the other hand, the user may adjust the setting with $environment_filter in
> ~/.sbuildrc. I consider severity to be somewhere between important and grave.
> However, if you intend to push current sbuild to Squeeze, I would consider this
> bug RC.
> 
> The patch (against current master) is attached.
> 
> -- System Information:
> Debian Release: 6.0
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (100, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 2.6.36-trunk-amd64 (SMP w/4 CPU cores)
> Locale: LANG=lt_LT.UTF-8, LC_CTYPE=lt_LT.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages libsbuild-perl depends on:
> ii  adduser                       3.112+nmu2 add and remove users and groups
> ii  apt                           0.8.10     Advanced front-end for dpkg
> ii  apt-utils                     0.8.10     APT utility programs
> ii  dctrl-tools                   2.14.5     Command-line tools to process Debi
> ii  devscripts                    2.10.69    scripts to make the life of a Debi
> ii  dpkg-dev                      1.15.8.7   Debian package development tools
> ii  exim4                         4.72-3     metapackage to ease Exim MTA (v4) 
> ii  exim4-daemon-light [mail-tran 4.72-3+b1  lightweight Exim MTA (v4) daemon
> ii  libdpkg-perl                  1.15.8.7   Dpkg perl modules
> ii  libfilesys-df-perl            0.92-3+b1  Module to obtain filesystem disk s
> ii  perl                          5.10.1-16  Larry Wall's Practical Extraction 
> ii  perl-modules [libio-zlib-perl 5.10.1-16  Core Perl modules
> ii  schroot                       1.4.17-1   Execute commands in a chroot envir
> 
> libsbuild-perl recommends no packages.
> 
> libsbuild-perl suggests no packages.
> 
> -- no debconf information

> >From fba0ecbb80fc76b7f358123250eebb88c893be4d Mon Sep 17 00:00:00 2001
> From: Modestas Vainius <modax at debian.org>
> Date: Sun, 2 Jan 2011 15:28:18 +0200
> Subject: [PATCH] Do not filter out environment variables starting with DEBIAN_ by default.
> 
> Notably, the fix enables export of DEBIAN_FRONTEND=noninteractive in the build
> environment.
> 
> Signed-off-by: Modestas Vainius <modax at debian.org>
> ---
>  lib/Sbuild/Conf.pm |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/Sbuild/Conf.pm b/lib/Sbuild/Conf.pm
> index 2b1bf31..65c518e 100644
> --- a/lib/Sbuild/Conf.pm
> +++ b/lib/Sbuild/Conf.pm
> @@ -373,7 +373,7 @@ sub setup ($) {
>  	    DEFAULT => {}
>  	},
>  	'ENVIRONMENT_FILTER'			=> {
> -	    DEFAULT => ['^DEB(SIGN)?_[A-Z_]+$',
> +	    DEFAULT => ['^DEB(IAN|SIGN)?_[A-Z_]+$',
>  	    		'^(C(PP|XX)?|LD|F)FLAGS(_APPEND)?$']
>  	},
>  	'LD_LIBRARY_PATH'			=> {
> -- 
> 1.7.2.3
> 

> _______________________________________________
> Buildd-tools-devel mailing list
> Buildd-tools-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/buildd-tools-devel


-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20110103/63b81571/attachment.pgp>