[buildd-tools-devel] Bug#631060: Bug#631060: Bug#631060: sbuild: Please highlight lintian failures

[Roger Leigh]

tags 631060 + fixed-upstream pending
thanks

On Sun, Jun 19, 2011 at 09:29:40PM +0200, Cyril Brulebois wrote:
> Roger Leigh <rleigh at codelibre.net> (19/06/2011):
> > As mentioned on IRC, it might make sense to fail the build
> > outright if lintian fails.  While probably not appropriate
> > for buildds (it would depend upon the lintian version on
> > the host, which could be too old or too new and hence result
> > in false positives) it would be useful for developers
> > building packages for upload.  OTOH, maybe just highlighting
> > in red would be sufficient for most cases.
> 
> Not all builds target the Debian archive. Not all archives implement
> lintian-based autorejects. Build host's lintian might be buggy (and
> overriding for a lintian bug which wouldn't be triggered on ftp-master
> looks bad). I can probably come up with a few more reasons not to do
> that.

I've committed a patch for this onto git master.  Lintian passes are
highlighted in green, failures in red.

If there are any other parts of the build log you would like
highlighting in the same way, it's just a list of regexes in
Sbuild::Build::open_build_log that are checked in the logger
process.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20110619/95430fc3/attachment.pgp>