[buildd-tools-devel] Bug#627854: Bug#627854: buildd: Please drop trailing empty line from .changes

[Roger Leigh]

On Tue, May 24, 2011 at 11:39:52PM +0200, Samuel Thibault wrote:
> ftp-master started refusing .changes files which have a trailing empty
> line (after the GPG end of signature). It happens that mutt introduces
> one when signing GPG in traditional mode. Other tools probably do too.
> buildd-mail-wrapper should probably drop it automatically, see attached
> patch.

> @@ -478,6 +478,8 @@ sub prepare_for_upload ($$) {
>      my $pkg = shift;
>      my $changes = shift;
>  
> +    $changes =~ s/\n+$/\n/;
> +
>      my( @files, @md5, @missing, @md5fail, $i );
>  
>      my @to_dists = $self->get_dists_from_changes( $changes );

Hi,

Thanks for the patch.  Has this been tested to work correctly
on a buildd?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20110526/1d4723b7/attachment.pgp>