[buildd-tools-devel] Bug#645223: schroot: 15killprocs has a race condition when killing processes

[Patrick Ohly]

Package: schroot

Invoking /bin/kill on processes fails if the process already
quit by itself while the schroot shutdown runs. Because of "set -e"
this causes the whole shutdown to fail.

I have seen this occasionally in a nightly testing setup involving
a D-Bus session: when the D-Bus daemon stops, all other processes
depending on it also shut down automatically, with or without being
killed.

Attached a patch which wraps kill in a function which merely logs
the problem instead of aborting.

-- System Information:
Debian Release: 6.0.2
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-xen-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set
to POSIX)
Shell: /bin/sh linked to /bin/dash

Versions of packages schroot depends on:
ii  libboost-filesystem1.4 1.42.0-4          filesystem operations
(portable pa
ii  libboost-program-optio 1.42.0-4          program options library for
C++
ii  libboost-regex1.42.0   1.42.0-4          regular expression library
for C++
ii  libboost-system1.42.0  1.42.0-4          Operating system (e.g.
diagnostics
ii  libc6                  2.11.2-10         Embedded GNU C Library:
Shared lib
ii  libgcc1                1:4.4.5-8         GCC support library
ii  liblockdev1            1.0.3-1.4         Run-time shared library for
lockin
ii  libpam0g               1.1.1-6.1         Pluggable Authentication
Modules l
ii  libstdc++6             4.4.5-8           The GNU Standard C++
Library v3
ii  libuuid1               2.17.2-9          Universally Unique ID
library
ii  schroot-common         1.4.19-1+squeeze1 common files for schroot

schroot recommends no packages.

Versions of packages schroot suggests:
pn  aufs-modules | unionfs-module <none>     (no description available)
pn  btrfs-tools                   <none>     (no description available)
pn  debootstrap                   <none>     (no description available)
pn  lvm2                          <none>     (no description available)
pn  unzip                         <none>     (no description available)

-- Configuration Files:
/etc/schroot/default/fstab changed [not included]
/etc/schroot/schroot.conf changed [not included]
/etc/schroot/setup.d/15killprocs changed [not included]

-- no debconf information


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15killprocs.patch
Type: text/x-patch
Size: 1534 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20111013/b0a5ac7a/attachment.bin>