[buildd-tools-devel] Bug#696841: libsbuild-perl: fails to parse configuration: uses undef as HASH ref (MAILTO_HASH)

[Thorsten Glaser]

Package: libsbuild-perl
Version: 0.63.2-1.1
Severity: grave
Tags: patch
Justification: renders package unusable

Hi,

without the patch below, sbuild/buildd fail to run
after writing a configuration file, with the error:

Starting Debian package autobuilder: buildd Error reading configuration: Can't use an undefined value as a HASH reference at /usr/share/perl5/Sbuild/ConfBase.pm line 83.

It exits with errorlevel 2 then, and buildd-mail also
spews lots of errors.

The patch below fixes this. Feel free to downgrade the
severity if this doesn't affect the majority of users,
but seeing as the official Debian buildds do not dogfood
the buildd suite in unstable, I am not so sure about that…

--- ConfBase.pm~
+++ ConfBase.pm
@@ -84,6 +84,7 @@ sub init_allowed_keys {
 		   $conf->get('MAILTO_HASH')->{$value})
 	    if ($value &&
 		$conf->get('DISTRIBUTION') &&
+		$conf->get('MAILTO_HASH') &&
 		$conf->get('MAILTO_HASH')->{$value});
     };
 


-- System Information:
Debian Release: 7.0
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: m68k

Kernel: Linux 3.2.0-4-atari
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/mksh-static

Versions of packages libsbuild-perl depends on:
ii  adduser                         3.113+nmu3
ii  apt                             0.9.7.7
ii  apt-utils                       0.9.7.7
ii  dctrl-tools                     2.22.2
ii  devscripts                      2.12.6
ii  dpkg-dev                        1.16.9
ii  libdpkg-perl                    1.16.9
ii  libexception-class-perl         1.32-1
ii  libfilesys-df-perl              0.92-4+b1
ii  libmime-lite-perl               3.028-1
ii  perl                            5.14.2-16
ii  perl-modules [libio-zlib-perl]  5.14.2-16
ii  postfix [mail-transport-agent]  2.9.5-1
ii  schroot                         1.6.4-4

libsbuild-perl recommends no packages.

libsbuild-perl suggests no packages.

-- no debconf information