[buildd-tools-devel] [PATCH] Output the contents of debian/files w/o a box

Roger Leigh rleigh at codelibre.net
Wed Jan 25 12:43:02 UTC 2012


On Wed, Jan 25, 2012 at 11:20:48AM +0100, Max Thoursie wrote:
> I don't think drawing a box around the contents of a file is appropriate
> since:
> 
> * Boxes are already used for headings which could be confusing if the
>   file only has one line.
> * It makes cut'n'pasting of the contents harder.

While this is true, is this a problem here?  I've never actually
seen this codepath triggered in the whole time I've worked on
sbuild, except during deliberate testing.  Removing this is no
problem, but I would be interested in whether this being
triggered is a regular occurence for you, and why.

I would also suggest putting a $self->log_sep(); before and after
the contents so that they remain delimited within the whole build
log.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20120125/421d50b8/attachment.pgp>


More information about the Buildd-tools-devel mailing list