[buildd-tools-devel] [PATCH] Output the contents of debian/files w/o a box

[Roger Leigh]

On Wed, Jan 25, 2012 at 01:07:15PM +0000, Roger Leigh wrote:
> On Wed, Jan 25, 2012 at 01:57:01PM +0100, Max Thoursie wrote:
> > On Wed, Jan 25, 2012 at 1:43 PM, Roger Leigh <rleigh at codelibre.net> wrote:
> > > On Wed, Jan 25, 2012 at 11:20:48AM +0100, Max Thoursie wrote:
> > >> I don't think drawing a box around the contents of a file is appropriate
> > >> since:
> > >>
> > >> * Boxes are already used for headings which could be confusing if the
> > >>   file only has one line.
> > >> * It makes cut'n'pasting of the contents harder.
> > >
> > > While this is true, is this a problem here?  I've never actually
> > > seen this codepath triggered in the whole time I've worked on
> > > sbuild, except during deliberate testing.  Removing this is no
> > > problem, but I would be interested in whether this being
> > > triggered is a regular occurence for you, and why.
> > 
> > I did actually trig this a couple of times with some of our
> > (misconfgured) projects. Sadly, I don't remember the actual bug
> > leading up to trigger this.
> > 
> > In addition to the above reasons, I didn't like the box since it
> > looked awful in the html-report I got it in. (The report generator
> > didn't handle the line drawing characters very well).
> 
> OK.  Does it also dislike the use of these as section separators
> as well?
> 
> > > I would also suggest putting a $self->log_sep(); before and after
> > > the contents so that they remain delimited within the whole build
> > > log.
> > 
> > Sounds like a good idea, do you want an updated patch?
> 
> Don't worry--it'll only take me 10 seconds to add.

I've pushed all your changes (modulo Build-Depends changes) to the
master branch.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.