[buildd-tools-devel] Bug#706086: sbuild: Wrong architecture check when --arch-all is given

[Stephan Suerken]

Package: sbuild
Version: 0.63.2-1.1
Severity: normal

Hi Roger,

   * What led up to the situation?

When building a package with two binary packages (arch1=all,
arch2=i386) with the --arch-all switch, the arch check wrongly
fails when not building on arch2.

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

Trying to build this

http://tmp.installiert.net/test_1.0.0.dsc

example test package with a command line like

$ sbuild --verbose --verbose --dist=unstable --arch=amd64 --chroot=SOME-SID-AMD64-CHROOT --arch-all --source --debbuildopt=-sa ./test_1.0.0.dsc

   * What was the outcome of this action?

sbuild skips building saying:

E: test_1.0.0.dsc: amd64 not in arch list or does not match any arch wildcards: all i386 -- skipping

   * What outcome did you expect instead?

Build the arch=all package.

As far as I understand (perl et.al.) I think that we should
check that "all" is IN the dscarchs string (which is s.th. like
"all i386"), not exactly "all".

Fwiw, it does work as expected with this (naive regex) change:

---
--- /usr/share/perl5/Sbuild/Build.pm.orig	2013-04-24 16:15:11.479881281 +0200
+++ /usr/share/perl5/Sbuild/Build.pm	2013-04-24 16:15:31.791937728 +0200
@@ -1003,7 +1003,7 @@
 	    }
 	}
 	if ($dscarchs ne "any" && !($valid_arch) &&
-	    !($dscarchs eq "all" && $self->get_conf('BUILD_ARCH_ALL')) )  {
+	    !($dscarchs =~ "all" && $self->get_conf('BUILD_ARCH_ALL')) )  {
 	    my $msg = "$dsc: $host_arch not in arch list or does not match any arch wildcards: $dscarchs -- skipping\n";
 	    $self->log($msg);
 	    Sbuild::Exception::Build->throw(error => "$dsc: $host_arch not in arch list or does not match any arch wildcards: $dscarchs -- skipping",
---

HtH!

Stephan

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-0.bpo.4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages sbuild depends on:
ii  adduser         3.113+nmu3
ii  apt-utils       0.9.7.8
ii  libsbuild-perl  0.63.2-1.1
ii  perl            5.14.2-21
ii  perl-modules    5.14.2-21

Versions of packages sbuild recommends:
ii  debootstrap  1.0.48
ii  fakeroot     1.18.4-2

Versions of packages sbuild suggests:
pn  deborphan  <none>
ii  wget       1.14-1

-- no debconf information