[buildd-tools-devel] Bug#699903: sbuild waits forever on 'Failed to copy' (stray exit call?)

[Stephan Sürken]

Package: sbuild
Version: 0.63.2-1.1
Severity: normal
Tags: patch

Dear Maintainers,

when sbuild triggers the 'Failed to copy error' (for example,
when running on a dsc file, with orig.tar.gz missing), sbuild
logs the error but then stalls.

It seems due to a strange exit/return combo in Build.pm. Just
removing 'exit' provides the expected (sbuild prints build stats
and exits with retval not 0) results:

--- Build.pm.orig	2013-02-06 13:28:50.995641502 +0000
+++ Build.pm	2013-02-06 13:30:42.435888257 +0000
@@ -779,7 +779,6 @@
     $self->check_abort();
     if (! File::Copy::copy($source, $dest)) {
 	$self->log_error("E: Failed to copy '$source' to '$dest': $!\n");
-	exit (1);
 	return 0;
     }

Looks just like a wrong code leftover. Hope it's that easy ;).

HtH,

Stephan

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-0.bpo.4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages sbuild depends on:
ii  adduser         3.113+nmu3
ii  apt-utils       0.9.7.7
ii  libsbuild-perl  0.63.2-1.1
ii  perl            5.14.2-17
ii  perl-modules    5.14.2-17

Versions of packages sbuild recommends:
pn  debootstrap  <none>
ii  fakeroot     1.18.4-2

Versions of packages sbuild suggests:
pn  deborphan  <none>
ii  wget       1.14-1

-- no debconf information