[buildd-tools-devel] Bug#722012: Bug#722012: Sbuild::Conf: missing use File::Spec

[Václav Ovsík]

On Sun, Sep 08, 2013 at 12:11:57AM +0100, Roger Leigh wrote:
>...
> Does this fix work for you?  Seems fine here with a cursory test.

bobek:~# sbuild-adduser zito
The user `zito' is already a member of `sbuild'.

# Setup tasks for sudo users:

# BUILD
# HOME directory in chroot, user:sbuild, 0770 perms, from
...


> Since the File::Spec->catfile is a class method call, I don't think that
> the "use File::Spec" is necessary here, or at the very least wasn't
> necessary previously.  I'm wondering if this is broken due to the recent
> Perl 5.18 transition since it was working fine before that.

Loading of the File::Spec ("require" File::Spec at least, "use" is more nice?)
is surely necessary. There is no need to import any symbols, but the Perl must 
load the module to use classes with it.

Missing File::Spec in the past may be working due to module was used by
some other module from Sbuild or any other Perl module Sbuild uses.
If the module was used by some Perl module included within it, then transition
to the version 5.18 can affect the bug I think.

Cheers
-- 
Zito