[buildd-tools-devel] Bug#742701: Bug#742701: Bug#742701: package built without _FORTIFY_SOURCE=2, debhelper or schroot issue?

[Roger Leigh]

On Wed, Mar 26, 2014 at 04:01:14PM +0000, Roger Leigh wrote:
> On Wed, Mar 26, 2014 at 03:01:37PM +0100, Matthias Klose wrote:
> > Package: debhelper,schroot
> > Severity: important
> > 
> > seen in unstable, according to
> > http://qa.debian.org/bls/packages/s/schroot.html
> > https://buildd.debian.org/status/fetch.php?pkg=schroot&arch=i386&ver=1.6.8-1&stamp=1388837978
> > 
> >  - schroot 1.6.8-1 sets debian/compat to 9
> >  - schroot sets DH_OPTIONS = --buildsystem=cmake
> > 
> > but CPPFLAGS are not appended to CFLAGS/CXXFLAGS as mentioned in
> > #668813. exporting DH_OPTIONS doesn't help either.
> > 
> > if you're not overwriting things like in korundum, appending the
> > CPPFLAGS seems to work. can't see what to fix in schroot.
> 
> Should simply be a matter of appending CPPFLAGS to CXXFLAGS?
> 
> From the description, #668813 sets CFLAGS, but doesn't mention
> CXXFLAGS--maybe it just needs updating to set both?

I checked the debhelper change, and it does set CXXFLAGS.  Looking at e.g.
https://buildd.debian.org/status/fetch.php?pkg=schroot&arch=powerpc&ver=1.6.8-1&stamp=1388838030:

  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security

are being added.  So at least some options are being set automatically.
Is _FORTIFY_SOURCE passed using a different mechanism or a different variable?
Or do I need to take some additional measure to explicitly enable it?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800