[buildd-tools-devel] Bug#765886: Bug#765886: sbuild: [PATCH] Replaced all unicode-printed chars with plain ASCII

[Roger Leigh]

tags 765886 - patch
thanks

On Sat, Oct 18, 2014 at 03:56:35PM -0700, Dima Kogan wrote:
> Sbuild likes to print out unicode characters, which improves the process
> very little, but is extremely annoying when it fails (when running on a
> non-unicode terminal, say). This patch replaces the unicode with ascii.

It's 2014; we've been using unicode by default for over a decade.  If your
terminal doesn't support UTF-8 input, it's in need for replacement.  Part
of the reason for doing this in sbuild was to enforce UTF-8 cleanliness
in sbuild, and tools processing the logs.

That said, we could certainly revert to ASCII for non-UTF-8 locales.  I
think your patch is too heavy-handed--it reverts to ASCII unconditionally.
However, if you make it conditional on "nl_langinfo(CODESET) != UTF8" this
will degrade gracefully for non-UTF-8 locales if you have a supplementary
non-Unicode set of formatting characters to substitute.  This should be
wrapped by POSIX.pm.  If you'd like to make this change, I'll be happy to
review and apply it.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800