[buildd-tools-devel] Bug#768091: Bug#768091: schroot: please support alternative compressions for file-based chroots

[Aurelien Jarno]

On Sun, Nov 09, 2014 at 06:21:58PM +0000, Roger Leigh wrote:
> On Tue, Nov 04, 2014 at 10:51:12PM +0100, Aurelien Jarno wrote:
> > schroot currently supports the gzip and bzip2 compressions for file-based
> > chroots. It might be worth to support alternative compressions to let
> > the user do a compromise between speed and space, depending for example
> > if the chroot is used often or not.
> > 
> > The patch below adds support for xz, lzop and lz4 compression, which
> > should cover most of the standard compression format available today.
> > Could you please apply it in one of the next uploads? Thanks.
> 
> Thanks for the patch.  It looks fine except for the lz4 case, which
> uses GNU tar-specific options and hardcodes the path to lz4 which is
> nonportable, and it also lacks an update to the docs in
> man/schroot.conf.5.man ("optionally compressed with...").
> 
> If you could fix it to use lz4 portably (I'd suggest piping) so it
> works with BSD tar, and also fix up the docs, I'll be happy to apply
> this.
> 

Thanks for the review. Please find attached a new version of the patch
which should address your comments.

Thanks,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                 http://www.aurel32.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-more-compression-formats.patch
Type: text/x-diff
Size: 3427 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20141113/20952c71/attachment.patch>