[buildd-tools-devel] Bug#762597: Bug#762597: Bug#762597: /var/lib/schroot/mounts should be in /var/run for --one-file-system

[Roger Leigh]

On Mon, Nov 24, 2014 at 06:00:23PM +0000, Ian Jackson wrote:
> Roger Leigh writes ("Re: [buildd-tools-devel] Bug#762597: /var/lib/schroot/mounts should be in /var/run for --one-file-system"):
> > Hmm, this is an interesting problem.  Your proposed solution would
> > certainly provide a boundary to stop traversal, but I'm not sure it
> > would help in all situations, since e.g. for file-based chroots we
> > unpack them under /var/lib/schroot.  Putting the mounts themselves
> > under /var/run should be safe enough though.
> 
> Yes, you're right, I hadn't properly considered file-based chroots.  I
> don't know how to fix those.  But as you say, my proposal at least
> won't hurt them.
> 
> > I'll need to do some testing of this to make sure it doesn't
> > break anything.  If you have any further thoughts or ideas, please
> > do let me know!
> 
> Thanks for your attention!

http://www.codelibre.net/~rleigh/schroot/ contains a sample amd64 build
and sources if you need to rebuild.  This

- switches SCHROOT_MOUNT_DIR to /var/run/schroot/mount
- adds a compatibility symlink on upgrade to transition smoothly

The packaging might need a little extra polishing, but works for me
and I'd be grateful if you could try testing it.  Things to tidy:

- make SCHROOT_MOUNT_DIR recursively in 10mount rather than hardcoding path
- don't install SCHROOT_MOUNT_DIR in upstream build scripts
- look at how to remove /var/lib/schroot/mount; it may have stuff
  underneath it, so removal is possibly highly unsafe; maybe just
  leave it?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800