[buildd-tools-devel] Bug#797114: sbuild: Please re-enable autoflush when using --nolog

[Christoph Biedl]

Package: sbuild
Version: 0.65.2-1
Severity: wishlist

Dear Maintainer,

as a part of my private build infrastructure, sbuild is called on a
remote host doing basically

    ssh $BUILDHOST -- \
        sbuild (...build options..) \
        --nolog --chroot $CHROOT $PACKAGE_$VERSION.dsc

After the jessie upgrade ... while this kept working in general,
instead of constant output the lines are shown in bigger chunks with
some pauses now. In other words: Buffering is no longer per line.

A diff soon led to the relevant change between wheezy and jessie:

--- /usr/share/perl5/Sbuild/Build.pm    
+++ /usr/share/perl5/Sbuild/Build.pm    
@@ -2232,9 +2232,6 @@
                if (-t $saved_stdout && $log_colour) {
                    print $saved_stdout color 'reset';
                }
-
-               # Manual flushing due to Perl 5.10 bug.  Should autoflush.
-               $saved_stdout->flush();
            }
            if (!$nolog && $log) {
                    print CPLOG $_;

Reverting that change also restored the previous and desired
behaviour. Therefore I'm asking you to revert that change, too.
Unless there's really good reason for this change.

Aside, the comment in the sources raises made me curious. What kind of
bug had to be worked around in Perl 5.10 (i.e. squeeze)? Was that
really fixed in wheezy and later?

Regards,
    Christoph

-- System Information:
Debian Release: 8.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.14.50 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20150827/e2a8c8b0/attachment.sig>