[buildd-tools-devel] Bug#751732: Bug#751732: Bug#751732: sbuild-createchroot: No overlay configured by default

[Johannes Schauer]

Control: tag -1 + pending

Hi,

On Thu, 24 Dec 2015 02:36:24 +0000 Wookey <wookey at wookware.org> wrote:
> +++ Johannes Schauer [2015-12-24 01:07 +0100]:
> > unfortunately the current synopsis of sbuild-createchroot is:
> > 
> > sbuild-createchroot [...] SUITE TARGET-DIRECTORY DEBIAN-MIRROR-URI
> > 
> > If tarball creation were to become the default, then the TARGET-DIRECTORY
> > positional argument would become a tarball path instead. Would this not break
> > backwards compatibility with users/scripts assuming that this argument is a
> > directory? It is even assumed to be a directory when adding the
> > --make-sbuild-tarball option.
> > 
> > So how about doing this instead:
> > 
> >  - promote the --make-sbuild-tarball option more in the EXAMPLES section of the
> >    sbuild-createchroot man page as it is already done in the sbuild wiki page.
> > 
> >  - when creating a directory based schroot, add union-type=overlay option by
> >    default
> > 
> > What do you think?
> 
> I think that would certianly be an improvement and agree that it would
> avoid incompatible/confusing changes.
> 
> I'm not sure how much of a problem changing the meaning of that param
> from dir to tarball-basename actually is in practice. Perhaps it would
> still be worth it, to get a 'better' default. Doing it at t ime when
> lots of sbuild things are changing anyway might make sense...
> 
> But I'm OK with taking the compatible route for now as that's easier and
> won't break anything.

attached patch is in my local git, should fix this bug and should be part of
the next sbuild release.

Thanks!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sbuild-createchroot-use-union-type-overlay-for-direc.patch
Type: text/x-diff
Size: 2557 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20151225/78c21f25/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20151225/78c21f25/attachment.sig>