[buildd-tools-devel] Bug#799056: Bug#799056: [PATCH] Add --source-only flag for only building the source package

[Johannes Schauer]

Hi,

Quoting Miguel A. Colón Vélez (2015-09-15 11:53:42)
> Here is the patch.

I did not try it out yet but here are some comments I have from reading it:

There seems to be a spurious hunk that escapes the minus in dpkg-buildpackage.
This should be part of a separate commit. On the other hand it seems that groff
upstream renders also un-escaped minuses as HYPHEN-MINUS. The lintian warning
is also no more. See #785353.

The docs for --source-only say:

 | The \-\-arch=\fIarchitecture\fP option can still be used to specify the
 | architecture used to build the package.

I do not see how this is relevant here and I also do not see how a user could
think that the --arch option could *not* still be used together with
--source-only. If you are worried that the user might not know how the --arch
option works then additional explanation of what it does should go into the
docs for the --arch option.

While we are at documentation:

Quoting Miguel A. Colón Vélez (2015-09-15 11:51:02)
> It's more elegant than cheating a bit and doing "-s --arch-all-only
> --no-arch-all" and then doing --post-build-commands "dput local-sbuild
> %r/%b/${FILE}_source.changes".

Reading the source code I can see how above ends up having the same effect as
the --source-only option you introduce in your patch. But your new option makes
this only even more confusing. For example the following:

 --source-only --arch-all-only

Would be equal to:

 --source --arch-all-only

Would be equal to:

 --arch-all-only --source

Would be equal to:

 --arch-all-only --no-arch-all --arch-all --source

None of this is obvious from the man page and the new --source-only option
makes it even more confusing. Thus, I'd really appreciate if

 - the documentation could be enhanced to explain that there are the three
   options BUILD_ARCH_ALL, BUILD_ARCH_ANY and BUILD_SOURCE
 - that those options are further documented in the man page of sbuild.conf
 - which command line option sets either of these to what with what effect
 - how the order of command line option potentially overwrites an earlier
   option
 - maybe group --arch-all-only, --source, --source-only and --no-arch-all in a
   separate section to do this explanation


Thanks!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20150928/d9b8bcb1/attachment-0001.sig>