[buildd-tools-devel] Bug#834515: sbuild-createchroot support of SUITE-VARIANT breaks when suite names contain dashes

[Raphaël Hertzog]

Package: sbuild
Version: 0.70.0-1
Severity: important
User: devel at kali.org
Usertags: origin-kali

Hello,

in Kali our main suite is named "kali-rolling" and our development
release is called "kali-dev".

When we try to use sbuild-createchroot, it will incorrectly assume
that "kali-rolling" is a variant of "kali" and will fail a bit later
trying to use the "kali" release (which used to exist at some point).

My suggestion is to add some intelligence in the code which decides
if it's a variant or a real release.

If there is a /usr/share/debootstrap/scripts/$suite, then assume it's
a real repository and not a variant. If it doesn't exist then try to
split on the last dash, and redo the same check to see if you split
at the correct place. Otherwise try the next dash (going from right to
left).

In Kali we have "kali-dev-only" and "kali-rolling-only" that should
be parsed as variants of kali-dev and kali-rolling respectively.
We also have kali-bleeding-edge which I shall rename into
kali-rolling-bleeding-edge to make it respect the naming logic
expected by sbuild-createchroot.

This has been broken in this version with the change developed
for #826957.

It would be better if debootstrap had some "--list-releases"
option so that we don't have to rely on implementation details
of debootstrap but this doesn't exist yet...

Alternatively, you need to add an option so that we can override
this variant detection logic.

Thank you!

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages sbuild depends on:
ii  adduser         3.115
ii  apt-utils       1.3~rc1
ii  libsbuild-perl  0.70.0-1
pn  perl:any        <none>

Versions of packages sbuild recommends:
ii  debootstrap  1.0.81
ii  fakeroot     1.21-1

Versions of packages sbuild suggests:
pn  deborphan  <none>
ii  wget       1.18-2+b1

-- no debconf information