[buildd-tools-devel] Bug#823993: Bug#823993: sbuild: bad foreach when reading the list of foreign architectures

[Johannes Schauer]

Hi,

Quoting Adam Borowski (2016-05-11 05:32:57)
> When there's actually a foreign arch configured, I get:
> 
> [~]# sbuild-update -udcar unstable-arm64
> Use of uninitialized value $_ in scalar chomp at /usr/share/perl5/Sbuild/ResolverBase.pm line 192.
> unstable-arm64: Performing update.
> (..., all ok, exit status 0)
> [~]# chroot /srv/sbuild/unstable-arm64/
> (unstable-arm64-sbuild)root at umbar:/# dpkg --print-foreign-architectures
> amd64
> (unstable-arm64-sbuild)root at umbar:/#
> 
> And the code in question is:
>     foreach my $arch (split /\s+/, $foreignarchs) {
>         chomp;
>         next unless $_;
>         $set{$_} = 1;
>     }
> 
> Note "my $arch" vs "$_".

thanks for finding this!

Indeed I did not test on chroots which already have foreign architectures from
the start as sbuild will be adding the required architectures itself.

I'm planning to upload a new Debian revision today with some patches from the
git master branch.  I assume you'd like me to make the fix for this part of
that upload because it otherwise pollutes stderr?

Thanks!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20160511/06296b79/attachment.sig>