[buildd-tools-devel] Bug#842947: sbuild: Disk usage is sometimes negative

[Santiago Vila]

Ok, I see that this -1 number is used deliberately:

  } else {
    $self->log_error("Cannot determine space needed for $file (unexpected du output): $space\n");
    return -1;
  }

but then, being a "special" value, I guess it was not meant to be shown "as is".

Maybe a fix would be to check that the value is not -1 before this:

    $self->log(sprintf("Build needed %02d:%02d:%02d, %dk disk space\n",
             $hours, $minutes, $seconds, $space));

or maybe people are supposed to interpret -1k as "don't trust this value"
from the above output?

Thanks.