[buildd-tools-devel] Bug#842281: sbuild: --extra-repository cannot be used with --no-apt-update

[Johannes Schauer]

Control: tag -1 + moreinfo

Hi,

On Thu, 27 Oct 2016 19:02:22 +0300 Ilias Tsitsimpis <i.tsitsimpis at gmail.com> wrote:
> Since commit 0e71b40, `--extra-repository' cannot be used with
> `--no-apt-update' (i.e., the extra repositories are not being used).

I would say that this is a feature instead of a bug. Imagine it were the other
way round and sbuild would run "apt-get update" even if --no-apt-update was
specified, then I would get another bug report "sbuild runs apt-get update even
though --no-apt-update was given".

With what justification would you still run "apt-get update" even if
--no-apt-update was passed? I would've said that a user who uses
--extra-repositories just must not use --no-apt-update. Maybe sbuild should
even print a warning if they attempt to do so.

Notice for example, that there also exists the --chroot-update-failed-commands
hook which will only get executed if "apt-get update" failed. A user might not
expect the code given by --chroot-update-failed-commands to be run if
--no-apt-update is in effect. They might experience unexpected side-effects if
that code is still run even though --no-apt-update is passed.

Thanks!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20161110/04e0c6c7/attachment.sig>