[Collab-qa-commits] r331 - tools/bugs2packagelist

[abi at alioth.debian.org]

Author: abi
Date: 2007-07-11 08:23:42 +0000 (Wed, 11 Jul 2007)
New Revision: 331

Modified:
   tools/bugs2packagelist/Notes
   tools/bugs2packagelist/bts2pkglist.pl
Log:
some more changes, no need to fetch the buglist if there is nothing to do .. update notes

Modified: tools/bugs2packagelist/Notes
===================================================================
--- tools/bugs2packagelist/Notes	2007-07-11 08:17:04 UTC (rev 330)
+++ tools/bugs2packagelist/Notes	2007-07-11 08:23:42 UTC (rev 331)
@@ -4,7 +4,7 @@
 	a usertag piuparts-test-<date_of_run> or archive-rebuild-<date_of_run>
 	and User: set to the QA groups mailadress.
 	
-	While working on the package list NNNNN: is added to the end of the
+	While working on the package list NNN: is added to the end of the
 	processed package line, which means a bug has been filed.
 
 	This script then goes ahead and fetches all the filed bugs for a

Modified: tools/bugs2packagelist/bts2pkglist.pl
===================================================================
--- tools/bugs2packagelist/bts2pkglist.pl	2007-07-11 08:17:04 UTC (rev 330)
+++ tools/bugs2packagelist/bts2pkglist.pl	2007-07-11 08:23:42 UTC (rev 331)
@@ -1,9 +1,8 @@
 #!/usr/bin/env perl
-# TODO!
-# this is just an example *what* should be done :)
+# see Notes
+# small script to fetch the filed bugs during a rebuild bug-triage
 use strict;
 use SOAP::Lite; 
-use Data::Dumper;
 
 sub do_help {
 	print "$0: <user_address> <usertag> <package_list_file>\n";
@@ -31,6 +30,15 @@
         exit 1;
 }
 
+open(INFILE, $pkglist) or die "unable to open Package list: $!";
+my @proc = grep(/NNN:/, <INFILE>);
+close(INFILE);
+
+if ( @proc < 1 ) {
+	print "nothing to do, no entries tagged with NNN: found\n";
+	exit 0;
+}
+
 my $c = new SOAP::Lite
     uri => '/Debbugs/SOAP',
     proxy => 'http://bugs.debian.org/cgi-bin/soap.cgi'
@@ -47,10 +55,6 @@
 	$l = $bugs->{"$user_tag"};
 }
 
-open(INFILE, $pkglist);
-my @proc = grep(/NNN:/, <INFILE>);
-close(INFILE);
-
 foreach my $line (@proc) {
 	my ($pkg, $tmp) = split(/ /, $line);