[Collab-qa-commits] r823 - svnbuildstat/trunk/lib/SvnBuildStat/Controller

[goneri at alioth.debian.org]

Author: goneri
Date: 2008-04-27 13:52:33 +0000 (Sun, 27 Apr 2008)
New Revision: 823

Modified:
   svnbuildstat/trunk/lib/SvnBuildStat/Controller/Controls.pm
Log:
fix a parse error

Modified: svnbuildstat/trunk/lib/SvnBuildStat/Controller/Controls.pm
===================================================================
--- svnbuildstat/trunk/lib/SvnBuildStat/Controller/Controls.pm	2008-04-27 12:46:56 UTC (rev 822)
+++ svnbuildstat/trunk/lib/SvnBuildStat/Controller/Controls.pm	2008-04-27 13:52:33 UTC (rev 823)
@@ -96,9 +96,10 @@
     $dscuri =~ s/\@REPOSITORY_URL@/$repositoryuri/;
     my $ret = "cookie=$cookie\n";
 
+    my $qajob;
     if ($params->{target} eq 'source') {
 
-        my $qajob = $c->model('SvnBuildStat::Model::DB::Qajob')->find_or_create(
+        $qajob = $c->model('SvnBuildStat::Model::DB::Qajob')->find_or_create(
             qatool_id => $qatool->id,
             changelogentry_id => $changelogentry_id,
             build_id => undef,
@@ -108,7 +109,7 @@
         
     } elsif ($params->{target} eq 'binary') {
 
-        my $qajob = $c->model('SvnBuildStat::Model::DB::Qajob')->find_or_create(
+        $qajob = $c->model('SvnBuildStat::Model::DB::Qajob')->find_or_create(
             qatool_id => $qatool->id,
             changelogentry_id => $changelogentry_id,
             build_id => $build_id, 
@@ -117,7 +118,8 @@
 
         $ret .= "qajob_id=".$qajob->id."\nchangesuri=".$changesuri."\n";
 
-    } else {die}
+    }
+    die unless $qajob;
 
     $qajob->lastjobstart("NOW");
     $qajob->update;