[Crosstoolchain-logs] [device-tree-compiler] 53/357: libfdt: Fix logic in nop_property testcase

[Hector Oron]

This is an automated email from the git hooks/post-receive script.

zumbi pushed a commit to branch upstream/1.3.x
in repository device-tree-compiler.

commit 41722c230c05b4a6ae0eec6c7537a73cb149a65e
Author: David Gibson <dgibson at sneetch.(none)>
Date:   Fri Dec 1 13:10:07 2006 +1100

    libfdt: Fix logic in nop_property testcase
    
    This patch fixes some completely bogus error checking logic from the
    nop_property testcase (resulted from a cut-and-paste error).
    
    Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
---
 tests/nop_property.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/nop_property.c b/tests/nop_property.c
index a8bed5b..94c8e74 100644
--- a/tests/nop_property.c
+++ b/tests/nop_property.c
@@ -57,15 +57,15 @@ int main(int argc, char *argv[])
 			     TEST_STRING_1);
 	verbose_printf("string value was \"%s\"\n", strp);
 	err = fdt_nop_property(fdt, 0, "prop-str");
-	err = fdt_ptr_error(intp);
+	if (err)
+		FAIL("Failed to nop \"prop-str\": %s", fdt_strerror(err));
+
+	strp = fdt_getprop(fdt, 0, "prop-str", NULL);
+	err = fdt_ptr_error(strp);
 	if (! err)
 		FAIL("prop-str still present after nopping");
 	if (err != FDT_ERR_NOTFOUND)
 		FAIL("Unexpected error on second getprop: %s", fdt_strerror(err));
 
-	strp = fdt_getprop(fdt, 0, "prop-str", NULL);
-	if (fdt_ptr_error(intp) != FDT_ERR_NOTFOUND)
-		FAIL("prop-str still present after nopping");
-
 	PASS();
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/crosstoolchain/device-tree-compiler.git