[Crosstoolchain-logs] [device-tree-compiler] 182/357: libfdt: Fix sw_tree1 testcase

Hector Oron zumbi at moszumanska.debian.org
Thu Dec 8 17:06:11 UTC 2016


This is an automated email from the git hooks/post-receive script.

zumbi pushed a commit to branch upstream/1.3.x
in repository device-tree-compiler.

commit d79d4e280f008a02b4da030b32189b5efbff7d89
Author: David Gibson <david at gibson.dropbear.id.au>
Date:   Tue Nov 6 10:42:45 2007 +1100

    libfdt: Fix sw_tree1 testcase
    
    There is a bug in the sw_tree1 testcase / utility which puts two
    "compatible" properties in one node in the output tree.  This patch
    fixes the bug, and also adds a new test checking that the sw_tree1
    output is equal to test_tree1.dtb as its supposed to be, which should
    catch future errors of this type.
    
    Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
---
 tests/run_tests.sh | 1 +
 tests/sw_tree1.c   | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 8fcc44a..278008b 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -70,6 +70,7 @@ libfdt_tests () {
     run_test sw_tree1
     tree1_tests sw_tree1.test.dtb
     tree1_tests unfinished_tree1.test.dtb
+    run_test dtbs_equal_ordered test_tree1.dtb sw_tree1.test.dtb
 
     # fdt_move tests
     for tree in test_tree1.dtb sw_tree1.test.dtb unfinished_tree1.test.dtb; do
diff --git a/tests/sw_tree1.c b/tests/sw_tree1.c
index 8784868..68551c3 100644
--- a/tests/sw_tree1.c
+++ b/tests/sw_tree1.c
@@ -64,7 +64,6 @@ int main(int argc, char *argv[])
 	CHECK(fdt_begin_node(fdt, "subsubnode"));
 	CHECK(fdt_property(fdt, "compatible", "subsubnode1\0subsubnode",
 			   23));
-	CHECK(fdt_property_string(fdt, "compatible", "subsubnode1\0"));
 	CHECK(fdt_property_typed(fdt, "prop-int", TEST_VALUE_1));
 	CHECK(fdt_end_node(fdt));
 	CHECK(fdt_end_node(fdt));

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/crosstoolchain/device-tree-compiler.git



More information about the Crosstoolchain-logs mailing list