[Crosstoolchain-logs] [device-tree-compiler] 312/357: dtc: Check return value from fwrite()

Hector Oron zumbi at moszumanska.debian.org
Thu Dec 8 17:06:27 UTC 2016


This is an automated email from the git hooks/post-receive script.

zumbi pushed a commit to branch upstream/1.3.x
in repository device-tree-compiler.

commit 0783d7e705f2d73f7148d9f45c600c2587b3c3ce
Author: David Gibson <david at gibson.dropbear.id.au>
Date:   Fri Nov 7 11:41:11 2008 +1100

    dtc: Check return value from fwrite()
    
    There's one place in flattree.c where we currently ignore the return
    value from fwrite().  On some gcc/glibc versions, where fwrite() is
    declared with attribute warn_unused_result, this causes a warning.
    
    This patch fixes the warning, by checking the fwrite() result.
    
    Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
---
 flattree.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/flattree.c b/flattree.c
index 50190b8..9197511 100644
--- a/flattree.c
+++ b/flattree.c
@@ -413,10 +413,13 @@ void dt_to_blob(FILE *f, struct boot_info *bi, int version)
 	if (padlen > 0)
 		blob = data_append_zeroes(blob, padlen);
 
-	fwrite(blob.val, blob.len, 1, f);
-
-	if (ferror(f))
-		die("Error writing device tree blob: %s\n", strerror(errno));
+	if (fwrite(blob.val, blob.len, 1, f) != 1) {
+		if (ferror(f))
+			die("Error writing device tree blob: %s\n",
+			    strerror(errno));
+		else
+			die("Short write on device tree blob\n");
+	}
 
 	/*
 	 * data_merge() frees the right-hand element so only the blob

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/crosstoolchain/device-tree-compiler.git



More information about the Crosstoolchain-logs mailing list