[Dbconfig-common-devel] SQLite Support

[sean finney]

hey matt,

i haven't had the chance to test it out just yet, but i spent a while
reading over the code and it looks really good.  a few questions/comments
below:

- could you go ahead and commit the "required changes" to trunk?  that
  is, the checks for dbtypes supporting "remote" or "authenticated"
  features.  i've made a few changes in trunk that will probably break
  a couple parts of the diff but nothing severe.  this would be the
  first step in bringing full support into trunk and will save us some
  merging headaches later on as trunk continue to lurch forward with
  unrelated fixes/additions.  also note that i've just sent 1.8.17
  out the door so you may want to merge your branch with trunk before
  merging back.

- do owner/mode really need to be prompted via debconf?  my guess is
  that most software won't work with non-default settings.  in any case,
  if they are provided by the admin, the settings should be retrieved
  from the files themselves and/or dpkg-statoverride (in other words, no
  reason to store it in the config file).  i'd also suggest that the
  default should be root:root/0640, since packagers are much more likely
  to notice that this default doesn't work it and fix it appropriately
  vs. packagers not noticing that their database is "sharing" data when
  it shouldn't.

- some of the functions in internal/sqlite won't fail gracefully in the
  case of code failure.  for example instead of:

	sqlite foo < bar
	retval=$?
	return $retval

  this will work better:

	retval=0
	sqlite foo < bar || retval=$?
	return $retval

  note that i'm not sure all of my code does it this way, though where
  it doesn't that's a bug :)  otherwise, depending on how it's called
  further up the chain it can cause the maintainer to prematurely exit
  if it's running with "set -e"

- here's a bunch of "because i've never used sqlite" type questions:
  - how are sqlite/sqlite2/etc different?  
    - is it just file formats?
    - sql/cmd syntax?  
    - cmdline programs?  
  - how many (or do any) applications support multiple sqlite versions
    simultaneously?  
  - are the file formats anything like backwards compatible?
  - are there commands to upgrade database formats?  if an app is likely to
    change versions we could hypothetically make an upgrade hook similar
    to the existing sql upgrade hooks.
  - how many (or do any) applications require multiple database files?



thanks!
	sean


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/dbconfig-common-devel/attachments/20060613/91260bb6/attachment.pgp