[Dbconfig-common-devel] Re: Bug#397089: dbconfig-common: migration fails when dbconfig-load-include returns empty values

[sean finney]

hey matt,

sorry for not getting back to this sooner.

On Sun, 2006-11-05 at 15:56 +1300, Matt Brown wrote:
> Matt Brown wrote:
> 
> > Ok, patch attached. 

one question:

+
+       # the load script needs to return at least a database type
+       if [ -z "$dbc_dbtype" ]; then
+               dbc_logline "failed"
+               return
+       fi
+

what if the app is a single dbtype application (and thus always has
dbc_dbtype set)?  otherwise, i agree with the approach, and it cleans
up the state machine area quite a bit which is a good thing.


	sean
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://lists.alioth.debian.org/pipermail/dbconfig-common-devel/attachments/20061106/3abcd47d/attachment.pgp