[Dctrl-tools-devel] Bug#383921: Bug#383921: Bug#476861: dctrl-tools: option to match against package-name boundaries

[Stefano Zacchiroli]

Eya, sorry for the delay, I'm back on track with this now.

[ reordering quoted text ]

On Fri, Feb 27, 2009 at 09:23:26AM +0100, Stefano Zacchiroli wrote:
> > You haven't signed off the patch.  Please read
> >   http://git.debian.org/?p=collab-maint/dctrl-tools.git;a=blob_plain;f=dco-1.1.txt;hb=dco
> > and if you can certify that, please add a Signed-Off-By line at the
> > end of the patch description (see debian/README).
> 
> Thanks, will do.
<snip>
> Sure, I'll squash all my changes into a single patch and push it.

Attached you can find a single patch, which has been Signed-Off-By me.

> > >  	if (atom->mode == M_REGEX || atom->mode == M_EREGEX) {
> > > +		regex_pat = calloc(1, regex_patlen);
> > Do you use the property that the returned memory is zeroed out?
> Yes. Will add an explicit comment about that; since you wondered, I
> guess others can wonder too.

I added a comment mentioning that I do rely on calloc 0-ing the
allocated memory, just in case.

> Nevertheless, that "implication" is currently annoying for the user
> because if you specify both -e and --whole-pkg you will get an
> error. What would be your preferred fix for this?

In the end, given that the error is shared also by other "weird" usage
patterns such as passing -e twice, I decided to simply mention in the
manpage that --whole-pkg does not only imply -e, but is also
incompatible with that.

> > Since you are a DD, you can commit it yourself when it's ready.
> > (Please read debian/README, first.)
> Thanks for the point, I overlooked that. I'll ping the bug report with
> the final patch version before pushing anyhow.

I'll push the very same commit you can find attached as patch ... as
soon as I will have finished reading that and discovered how to push
;-)

Cheers.

-- 
Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
zack@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..|  .  |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...........| ..: |.... Je dis tu à tous ceux que j'aime