[Debburn-changes] r334 - in nonameyet/trunk: . mkisofs

[Eduard Bloch]

Author: blade
Date: 2006-09-25 16:45:56 +0000 (Mon, 25 Sep 2006)
New Revision: 334

Modified:
   nonameyet/trunk/TODO
   nonameyet/trunk/mkisofs/dvd_file.c
Log:
a small TODO for the future, sorting algorithm optimisation


Modified: nonameyet/trunk/TODO
===================================================================
--- nonameyet/trunk/TODO	2006-09-24 17:27:24 UTC (rev 333)
+++ nonameyet/trunk/TODO	2006-09-25 16:45:56 UTC (rev 334)
@@ -12,6 +12,7 @@
  - add better detection for various functions. Eg. correct checks for have_soundcard, have_mlockall for cygwin. (volunteers?)
  - see http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=cdrkit and try to solve upstream related problems
  - find and eliminate remaining ".mk" ".mk*" files (where? cleanup branch)
+ - review the sort/uniq code in dvd_file.c, see comments there
  - Can we rename the 'cdrecord' directory into 'wodim'?
  That may be hard on the build system, this could be the best time to change
  it. (No, it isn't hard. Just needs a good moment to settle down everything and

Modified: nonameyet/trunk/mkisofs/dvd_file.c
===================================================================
--- nonameyet/trunk/mkisofs/dvd_file.c	2006-09-24 17:27:24 UTC (rev 333)
+++ nonameyet/trunk/mkisofs/dvd_file.c	2006-09-25 16:45:56 UTC (rev 334)
@@ -67,6 +67,8 @@
 	int	i;
 	int	j;
 
+  /* this is not bubble sort, this is primitive selection sort. Replace with
+   * bubble sort later, maybe bidirectional, aka Coctail Sort */
 	for (i = 0; i < size; i++) {
 		for (j = 0; j < size; j++) {
 			if (sector[i] < sector[j]) {