[Debburn-devel] [PATCH] cleanup: eliminate CHAR_IS_UNSIGNED

Peter Samuelson peter at p12n.org
Tue Sep 5 07:32:53 UTC 2006


I see no reason for the CHAR_IS_UNSIGNED macro; we can delete it.  We
aren't setting it correctly in xconfig.h anyway.


Index: include/utypes.h
===================================================================
--- include/utypes.h	(revisione 215)
+++ include/utypes.h	(copia locale)
@@ -92,12 +92,6 @@
 #define	_INCL_SYS_TYPES_H
 #endif
 
-#ifdef	__CHAR_UNSIGNED__	/* GNU GCC define (dynamic)	*/
-#ifndef CHAR_IS_UNSIGNED
-#define	CHAR_IS_UNSIGNED	/* Sing Schily define (static)	*/
-#endif
-#endif
-
 /*
  * Several unsigned cardinal types
  */
@@ -204,11 +198,7 @@
 error  Sizeof char is not equal 1
 #endif
 
-#if	defined(__STDC__) || defined(CHAR_IS_UNSIGNED)
-	typedef	signed char		Int8_t;
-#else
-	typedef	char			Int8_t;
-#endif
+typedef signed char			Int8_t;
 
 #if SIZEOF_SHORT_INT == 2
 	typedef	short			Int16_t;
Index: include/xconfig.h.in
===================================================================
--- include/xconfig.h.in	(revisione 215)
+++ include/xconfig.h.in	(copia locale)
@@ -411,7 +411,6 @@
 #define SIZEOF_UNSIGNED_CHAR_P @SIZE_PTR@
 
 #define HAVE_LONGLONG 1		/* Compiler defines long long type */
-/* #undef CHAR_IS_UNSIGNED */		/* Compiler defines char to be unsigned */
 
 /* #undef const */			/* Define to empty if const doesn't work */
 /* #undef uid_t */			/* To be used if uid_t is not present  */
Index: include/mconfig.h
===================================================================
--- include/mconfig.h	(revisione 215)
+++ include/mconfig.h	(copia locale)
@@ -319,12 +319,6 @@
 #	endif
 #endif
 
-#ifdef	__CHAR_UNSIGNED__	/* GNU GCC define (dynamic)	*/
-#ifndef CHAR_IS_UNSIGNED
-#define	CHAR_IS_UNSIGNED	/* Sing Schily define (static)	*/
-#endif
-#endif
-
 /*
  * Convert to GNU name
  */
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/debburn-devel/attachments/20060905/49727741/attachment.pgp


More information about the Debburn-devel mailing list