[Debburn-devel] [PATCH] cleanup: Use ANSI-style function definitions in cdrecord.c

[Christian Fromme]

>
> [Christian Fromme]
>>
>>  EXPORT int
>> -main(ac, av)
>> -	int	ac;
>> -	char	*av[];
>> +main(int argc, char *argv[])
>
> At that point I'd take the opportunity to remove the EXPORT.  'int
> main(...)' is correct ANSI C.

Good idea, I was thinking about the exact same thing.

>> +print_track(int track, long lba, struct msf *msp, int adr, int control,
>> int mode)
>
> 80 columns, if you would, please.
>
> I'm actually not insistent upon the 80-column rule - we do all have
> resizable xterms in this day and age - but it _is_ a good general rule
> of thumb, to keep lines from becoming unreadably long.

I think 80 columns is worth keeping as a standard. I simply didn't format
this code to wrap always exactly at 80 columns bebause JS didn't bother
about it anywhere in his code as far as I could see.

Thanks for the input, I will keep your suggestions in mind for the next
patches!

Have a nice day,
Christian