[Debburn-devel] [PATCH for branches/cleanup] make sccsid static const char[]

[Lorenz Minder]

Hi,

Peter Samuelson wrote:
> [Lorenz Minder]
> > This patch makes sccsid in various source file static const char[], so
> > gcc won't complain about a defined, but unused, variable.
> 
> Why do we even keep the sccsid variables?  We are never going to go
> back to SCCS.  The only reason to keep them is that they include a
> copyright statement. I believe Albert's last patch removes some or all
> of these, in places where the same copyright declaration already exists
> in a source comment.  That's the better approach.

I have no strong opinion about this. But since, unlike the source code
comments, those copyright notice also end up in the executable, and that
this was cleary the intent of these lines, I'm not sure if it is
appropriate to remove them.

Anyway, if there is a general consensus that those warnings can and
should be removed, I'd be happy if someone applied the noncontroversial
part of Albert's patch soon; so I don't get the output of "make"
cluttered with useless warnings.

Best,
--Lorenz