[debhelper-devel] [PATCH] Put extra options after dh-generated ones

[Niels Thykier]

On 2015-08-27 20:19, KAction at gnu.org wrote:
> From: Dmitry Bogatov <KAction at gnu.org>
> 

Hi,

Thanks for your interest.

I have two concerns about this patch.  Please consider the following
example:

  dh $@ --with foo,bar,baz

If the "foo" module passes "--" to dh_shlibdeps, then "bar" nor "baz"
can pass a debhelper option dh_shlibdeps.  If "bar" also want to pass a
"--" to dh_shlibdeps, then the modules cannot be used together.

Accordingly, I do not think your patch solves your use-case sufficiently
to the extend where we can recommend people to use it in general.
  Separately, applying this patch would also mean that options passed by
the user is now overruled by the sequencer.  I am not entirely sure if
this make sense

As for moving forward.  Maybe we need a different method for passing
"non-options" that are passed after an "--"?  It seems like it would
solve your use-case and interact better with other sequence extensions.

> Put options added by `add_command_options` for dh_* commands *after*
> ones, passed by dh(1) itself, e.g -O--buildsystem=haskell.
> 
> This change solve following issue with dh_shlibdeps(1), which allow
> to pass raw arguments to underlying dpkg-shlibdeps(1) after `--`
> argument.
> [...]


Re: "allow to", you are probably looking for a different word
(please see http://www.xibalba.demon.co.uk/jbr/linux/esl.html#b1 for the
extended explanation).

Thanks,
~Niels





-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20150830/1c2bd402/attachment-0001.sig>