[debhelper-devel] Bug#802984: Certain errors config obscured by sloppy handling of $@

[Jonathan Hall]

Package: debhelper
Version: 9.20151005
Tags: patch

Debian::Debhelper::Buildsystem::cmake::configure() contains a subtle bug 
which
swallows $@ for certain error conditions.

I discovered the bug while trying to build digikam, which fails with 
this error:

Died at /usr/share/perl5/Debian/Debhelper/Buildsystem/cmake.pm line 93.
debian/rules:19: recipe for target 'override_dh_auto_configure' failed

But it should die with this error:

dh_auto_configure: cmake .. -DCMAKE_INSTALL_PREFIX=/usr 
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None 
-DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var 
-DCMAKE_BUILD_TYPE=Debian -DCMAKE_INSTALL_RPATH=/usr/lib/digikam 
-DDIGIKAMSC_COMPILE_DOC=on -DDIGIKAMSC_COMPILE_PO=on -DENABLE_LCMS2=ON 
-DKDE4_BUILD_TESTS=OFF -DDIGIKAMSC_USE_PRIVATE_KDEGRAPHICS=OFF returned 
exit code 1
debian/rules:19: recipe for target 'override_dh_auto_configure' failed

The solution is simple, and included as a patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: errorfix.patch
Type: text/x-patch
Size: 936 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20151025/108f1dd2/attachment-0001.bin>