[debhelper-devel] [debhelper] 01/01: Dh_Lib: Validate trigger types

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository debhelper.

commit 10aa93aa5dfae31fc09371f397fc6d4bd7937cf2
Author: Niels Thykier <niels at thykier.net>
Date:   Fri Sep 11 15:41:08 2015 +0200

    Dh_Lib: Validate trigger types
    
    Thanks to Peter Pentchev for noticing that this check was missing.
    
    Signed-off-by: Niels Thykier <niels at thykier.net>
---
 Debian/Debhelper/Dh_Lib.pm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Debian/Debhelper/Dh_Lib.pm b/Debian/Debhelper/Dh_Lib.pm
index fd50cb4..a5743e9 100644
--- a/Debian/Debhelper/Dh_Lib.pm
+++ b/Debian/Debhelper/Dh_Lib.pm
@@ -640,8 +640,14 @@ sub autoscript_sed {
 
 	sub autotrigger {
 		my ($package, $trigger_type, $trigger_target) = @_;
-		my $triggers_file = generated_file($package, 'triggers');
-		my $ifd;
+		my ($triggers_file, $ifd);
+
+		if (not exists($VALID_TRIGGER_TYPES{$trigger_type})) {
+			require Carp;
+			confess("Invalid/unknown trigger ${trigger_type}");
+		}
+
+		$triggers_file = generated_file($package, 'triggers');
 		if ( -f $triggers_file ) {
 			open($ifd, '<', $triggers_file)
 				or error("open $triggers_file failed $!");

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debhelper/debhelper.git