[debhelper-devel] Bug#794898: Bug#794898: debhelper: [PATCH] dh_compress: fix specifying file lists

[Niels Thykier]

Control: tags -1 moreinfo

On 2015-08-07 21:26, Rafael Kitover wrote:
> Package: debhelper
> Version: 9.20150101ubuntu1
> Severity: normal
> Tags: patch
> 
> When you specify a file list in rules to compress by e.g.:
> 
> override_dh_compress:
>     dh_compress -- usr/share/doc/file1.txt usr/share/doc/file2.txt
> 
> If, for example, file1.txt is greater than 4k and dh_compress would
> compress it anyway, then specifying it causes it to be duplicated and
> causes the command to fail.
> 
> This patch fixes this problem by removing duplicates from the file list,
> and also allows absolute paths in the file lists.
> 
> A test is included for the default and the desired behavior.
> 
> The patch is against debhelper git (via debcheckout debhelper.)
> [...]


Hi,

Thanks for taking the time to write this patch and sorry for my sloppiness.

At a quick glance, I am a bit concerned with the handling of @ARGV,
where it unconditionally strip the leading slash.  Are you confident
that is correct?  "ln -s foo/bar link-name" is very different from "ln
-s /foo/bar link-name"

Thanks,
~Niels