[debhelper-devel] Bug#822669: debhelper: dh_installinit add autoscript for non-existent init script when service file exists

[Raphael Hertzog]

On Tue, 26 Apr 2016, Tianon Gravi wrote:
> (the "[ -x "/etc/init.d/#SCRIPT#" ]" bit,
> https://anonscm.debian.org/cgit/debhelper/debhelper.git/tree/autoscripts/postinst-init)
> 
> Is this check not working properly?

It is working... but as you noted since we know that there is not init
script, we could as well get rid of those.

> > Furthermore the presence of those snippets lead to lintian
> > warnings/errors:
> > W: hostapd-wpe: init.d-script-not-marked-as-conffile etc/init.d/hostapd-wpe
> > E: hostapd-wpe: init.d-script-not-included-in-package etc/init.d/hostapd-wpe
> 
> The lintian warnings are strange, and I think should be considered a
> false-positive in the lintian code itself (since the lines they're
> detecting in postinit are wrapped by an appropriate conditional). :(

So if you don't think that you can drop those lines easily, you might
want to clone this bug against lintian to get those errors fixed, i.e.
linitian should not assume that the package is supposed to contain an
init script if the postints contains those lines.

> I looked a little bit at the dh_installinit code to see how easy it
> would be to remove these lines completely when they're not necessary,
> but it's definitely not trivial (which I think is why the "if"
> statement was added in the first place).

It's probably easier to fix this is when you tackle #822670 (full support
of systemd units as currently provide by dh-systemd).

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/