[debhelper-devel] Bug#568897: Bug#568897: Bug#568897: debhelper: DEB_BUILD_OPTIONS=nocheck should prevent override_dh_auto_test rule to be run

[Peter Pentchev]

On Mon, Dec 12, 2016 at 09:23:40PM -0600, Steve M. Robbins wrote:
> On Monday, December 12, 2016 10:57:20 AM CST Peter Pentchev wrote:
> > On Sun, Dec 11, 2016 at 08:22:09PM -0600, Steve M. Robbins wrote:
> 
> > > Alternatively: if the logic was all in dh (to skip both dh_auto_test
> > > and override_dh_auto_test), then it would not need to be in
> > > dh_auto_test at all.
> > 
> > It may still need to be in dh_auto_test for packages that still do not
> > use the override targets at all, but invoke the dh_* commands explicitly
> > from the "build", "binary", etc targets.  None of mine do, but I bet that
> > there are still some in the archive :)
> 
> You're suggesting someone would use dh_auto_test from within a binary target?   
> Interesting use case.   

Um, no, not really, those were practically two different statements.  I was
suggesting that somebody might write (or not have converted yet) a rules file
that invokes dh_auto_test directly from within the "build" target, and then
I gave '"build", "binary", etc' as an enumeration of examples of targets that
somebody might invoke the dh_* commands directly from :)

> My feeling is that DEB_BUILD_OPTIONS represent global build options, so I 
> think I'd design it into dh rather than individual tools.  You're right that 
> it would be a breaking change, but I think one could use a debhelper 
> compatibility level to remove the functionality from the tools.  

Hmm, but would this not mean that writing rules files that invoke the tools
directly would no longer be supported?  Also, more importantly, this would
break override targets that *do* invoke the respective tool and expect it to
do its job exactly as if invoked automatically by dh, but pass it some more
options, e.g.:

override_dh_auto_build:
	dh_auto_build -- -C weirdsrc

In this case I would certainly expect dh_auto_build to honor, say, "noopt" in
DEB_BUILD_OPTIONS.

G'luck,
Peter

-- 
Peter Pentchev  roam at ringlet.net roam at FreeBSD.org pp at storpool.com
PGP key:        http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115  C354 651E EFB0 2527 DF13
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20161213/a0204386/attachment-0003.sig>