[debhelper-devel] Bug#814754: apt: improper usage of dpkg-maintscript-helper

[Julian Andres Klode]

Control: clone -1 -2
Control: reassign -2 debhelper
Control: retitle -2 debhelper: Clarify use of maintscript

On Mon, Feb 15, 2016 at 03:57:13AM +0100, Andreas Beckmann wrote:
> Package: apt
> Version: 1.2.3
> Severity: important
> 
> Hi,
> 
> while debugging an issue found by piuparts on upgrading from jessie to
> stretch I stumbled upon this debug output from dpkg-maintscript-helper:
> 
>   Setting up apt (1.2.3) ...
>   Installing new version of config file /etc/apt/apt.conf.d/01autoremove ...
>   Installing new version of config file /etc/cron.daily/apt ...
>   Installing new version of config file /etc/kernel/postinst.d/apt-auto-removal ...
>   usermod: no changes
>   DEBUG: dpkg-maintscript-helper: Executing /usr/bin/dpkg-maintscript-helper rm_conffile in postinst of apt
>   DEBUG: dpkg-maintscript-helper: CONFFILE=/etc/apt/apt.conf.d/20changelog PACKAGE=apt:amd64 LASTVERSION=1.0.3 ACTION=@ PARAM=--
> 
> This looks like dpkg-maintscript-helper gets called with the wrong
> parameters ... how does apt.maintscript look like?
> 
>     rm_conffile /etc/apt/apt.conf.d/20changelog 1.0.3 -- "@"
> 
> yes, that's bullshit. 

The documentation should be fixed to mention that. The manpage says:

dpkg-maintscript-helper(1):
  dpkg-maintscript-helper command [parameter...] --  maint-script-parameter...
dh_installdeb(1):
  lines in this file correspond to dpkg-maintscript-helper(1) commands and parameters.

It's unclear.

> Correct would be
> 
>     rm_conffile /etc/apt/apt.conf.d/20changelog 1.2.4~
> 
> So this has never worked since it was introduced in 2014 ...
> Version bumped assuming the fixed version will be uploaded as 1.2.4.
> 
> 
> Andreas
> 

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

When replying, only quote what is necessary, and write each reply
directly below the part(s) it pertains to (`inline'). Thank you.