[debhelper-devel] Actually enable dh_installinit -R in compat level 10?

[Peter Pentchev]

On Tue, Jul 19, 2016 at 02:53:12PM +0300, Peter Pentchev wrote:
> Hi,
> 
> It looks like the manual page statement that -R (--restart-after-upgrade)
> is enabled by default in compat level 10 is not entirely true.  What do
> you think about the attached trivial patch that makes it a bit more true? :)
> 
> Hm, I was wondering... would you like me to file a bug so that this may
> be tracked across the various versions of debhelper in the archive's suites?
> I'm not sure if any packages depend on -R by default yet, but if they do,
> they are currently broken (dh_installinit stops the service before
> the upgrade and starts it afterwards).

Erm, and, of course, the same holds for dh_systemd_start :)

G'luck,
Peter

-- 
Peter Pentchev  roam at ringlet.net roam at FreeBSD.org pp at storpool.com
PGP key:        http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115  C354 651E EFB0 2527 DF13
-------------- next part --------------
From 3f41a56e01fcfd5eecc91fda8832e4cda3499a49 Mon Sep 17 00:00:00 2001
From: Peter Pentchev <roam at ringlet.net>
Date: Tue, 19 Jul 2016 14:58:51 +0300
Subject: [PATCH 2/2] dh_systemd_start: --restart-after-upgrade in compat 10.

---
 dh_systemd_start | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dh_systemd_start b/dh_systemd_start
index 2aa5ea9..9914bbd 100755
--- a/dh_systemd_start
+++ b/dh_systemd_start
@@ -76,7 +76,7 @@ B<dh_systemd_start> manually.
 
 =cut
 
-$dh{RESTART_AFTER_UPGRADE} = 1 if not compat(10);
+$dh{RESTART_AFTER_UPGRADE} = 1 if not compat(9);
 
 init(options => {
 	"r" => \$dh{R_FLAG},
-- 
2.8.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20160719/f346a65f/attachment.sig>