[debhelper-devel] Bug#844504: debhelper: please stop doing autoreconf when build system is cmake

[Gianfranco Costamagna]

Source: debhelper
Version: 10.2.2
Severity: normal

Hi, I noticed a build failure everywhere with libpng1.6 in experimental.

changes are the switch to cmake, and a bug in the experimental resolver picking the wrong autotools.

The main issue seems however to be in debhelper, why is it running autoreconf with --buildsystem=cmake?

quoting the build log [1].
I just depend on cmake, not on dh-autoreconf, neither autoreconf or autoconf*

dpkg-buildpackage: info: source package libpng1.6
dpkg-buildpackage: info: source version 1.6.26-3
dpkg-buildpackage: info: source distribution experimental
dpkg-source --before-build libpng1.6-1.6.26
dpkg-buildpackage: info: host architecture amd64
fakeroot debian/rules clean
dh clean --buildsystem=cmake
dh_testdir -O--buildsystem=cmake
dh_auto_clean -O--buildsystem=cmake
dh_autoreconf_clean -O--buildsystem=cmake
dh_clean -O--buildsystem=cmake
debian/rules build-arch
dh build-arch --buildsystem=cmake
dh_testdir -a -O--buildsystem=cmake
dh_update_autotools_config -a -O--buildsystem=cmake
dh_autoreconf -a -O--buildsystem=cmake
main::scan_file() called too early to check prototype at /usr/bin/aclocal line 644.
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'scripts'.
libtoolize: copying file 'scripts/libtool.m4'
libtoolize: copying file 'scripts/ltoptions.m4'
libtoolize: copying file 'scripts/ltsugar.m4'
libtoolize: copying file 'scripts/ltversion.m4'
libtoolize: copying file 'scripts/lt~obsolete.m4'
main::scan_file() called too early to check prototype at /usr/bin/aclocal line 644.
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\${ <-- HERE ([^ \t=:+{}]+)}/ at /usr/bin/automake line 4159.
configure.ac:37: require Automake 1.13, but have 1.11.6
autoreconf: automake failed with exit status: 1
dh_autoreconf: autoreconf -f -i returned exit code 1
debian/rules:14: recipe for target 'build-arch' failed
make: *** [build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2

[1] https://buildd.debian.org/status/fetch.php?pkg=libpng1.6&arch=amd64&ver=1.6.26-3&stamp=1479248169

I would appreciate dh-autoreconf being a no-op in case buildsystem is cmake
(I'm not even sure if this is a bug, and if this is in debhelper or dh-autoreconf, or whatever, feel free to reassing
in case)


thanks!

cheers,

G.