[debhelper-devel] Bug#805878: dh-systemd: dh_systemd_start --no-start --restart-after-upgrade causes the service to be started on install

[Michael Biebl]

Control: severity -1 important

On Mon, 23 Nov 2015 11:34:47 -0300 Felipe Sateler <fsateler at debian.org>
wrote:
> Package: dh-systemd
> Version: 1.24
> Severity: normal
> 
> Current autoscript has:
> 
> if [ -d /run/systemd/system ]; then
>         systemctl --system daemon-reload >/dev/null || true
>         if [ -n "$2" : ]; then
>                 _dh_action=try-restart
>         else
>                 _dh_action=start
>         fi
>         deb-systemd-invoke $_dh_action #UNITFILES# >/dev/null || true
> fi
> 
> 
> And this does not take into account that --no-start was passed. If it
> was passed, then try-restart should always be used.
> 

Now that compat level 10 has --restart-after-upgrade as default, this
bug has a wider impact (thus bumping the severity).

With compat level 9 and older, --no-start did not generate any
maintainer scripts code at all.

Aside from the bug that "start" is used on new installs, I wonder if we
should (try-)restart the service at all.

Thoughts?


Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20161013/efa70752/attachment-0001.sig>