[debhelper-devel] Bug#841095: dh-systemd: dh_systemd_start should not act on Also=

[Michael Biebl]

Package: debhelper
Version: 10.2.2
Severity: normal

In the network-manager package, I have a unit file NetworkManager.service
containing:

...
[Install]
Also=NetworkManager-dispatcher.service

As a result, dh_systemd_start is generating code to (re)start this
service, even though I used
dh_systemd_start -pnetwork-manager NetworkManager.service

My expectation in this case is, that dh_systemd_start only acts on the
NetworkManager.service unit.
There is an undocumented --no-also switch for dh_systemd_start, which I
used for the time being [1].

I think though, that Also= from the [Install] section should only ever
be considered when enabling/disabling a service, not when
starting/stopping it.

Looking at [2], it talks about enabling/disabling which is odd, as if
this should belong into dh_systemd_enable.


[1] https://anonscm.debian.org/cgit/pkg-utopia/network-manager.git/commit/?id=f0ffa34f24
[2] https://anonscm.debian.org/git/debhelper/debhelper.git/tree/dh_systemd_start#n198
-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.7.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages debhelper depends on:
ii  autotools-dev            20160430.1
ii  binutils                 2.27-8
ii  dh-autoreconf            12
ii  dh-strip-nondeterminism  0.028-1
ii  dpkg                     1.18.10
ii  dpkg-dev                 1.18.10
ii  file                     1:5.28-4
ii  libdpkg-perl             1.18.10
ii  man-db                   2.7.5-1
ii  perl                     5.24.1~rc3-3
ii  po-debconf               1.0.20

debhelper recommends no packages.

Versions of packages debhelper suggests:
ii  dh-make  2.201608

-- no debconf information