[debhelper-devel] Bug#415396: Bug#415396: "dh_install --list-missing" should ignore manpages and other installed files

[Niels Thykier]

Niels Thykier:
> Michael Stapelberg:
>> On Sun, Mar 26, 2017 at 2:54 PM, Niels Thykier <niels at thykier.net> wrote:
>>
>> [...]
>>
>> Great. Find attached an updated patch including documentation.
>>
> 
> Thanks.  I am a bit busy this week, so odds are I will not have time to
> look at it until the weekend at the earliest.  Please ping me if you
> have not heard from me on this by Tuesday.
> 

Created a branch for it:

https://anonscm.debian.org/git/debhelper/debhelper.git/log/?h=bug-415396-dh_missing

Review welcome.  Note that the "installed-by" files work differently
than documented.  I have opted for keeping the behaviour and correcting
the documentation.

> If you got time to spare and want to keep things moving, I got some
> things I am considering to change:
> 
>  * Make log_installed_files use "basename($0)" rather than taking an
>    argument for the "helper name".  The actual file name is an
>    implementation-detail anyway, and tool writers do not benefit from
>    the addition complexity
> 

Done.

>  * Make log_installed_files support being called multiple times from
>    the same helper to make it easier for tool writers.  Most of them
>    probably don't need to accumulate their set of installed/processed
>    files.  dh_install basically only does it because it was implementing
>    the "missing" feature AFAICT.
> 

Done.  This will probably come in handby due to the next item and the
following call pattern.

 dh_install -ppkg foo bar
 dh_install --remaining

> If you want to start on dh_installman (or other tools):
> 
>  * CAVEAT: The tools have to start acting on *all* packages but
>    "do nothing" for "uninteresting packages" like dh_install does.
>    Otherwise, the user will see "missing" entries when doing an
>    dpkg-buildpackage -B build (or -A).
> 


Did a prototype for dh_installman, which seems to be working (with the
above CAVEAT)

NB: Due to how this is implemented, the "install-by" files will get
duplicates when you do:

  dh_install -a # first copy
  dh_install -i # second copy

It does not appear to be a problem atm., so I have left it at that.

> The debhelper API here is probably horribly lacking IRT making this
> easy.  So far, it has only been done in dh_install, but it is a
> necessity for this feature to work correctly (Especially with
> --fail-missing).  Bonus points for improving that. :)
> 

Still lacking.

>> Is there any large-scale testing that debhelper has, to confirm that my
>> change doesn’t break things so far?
>>
> 
> No.  But I suppose we could do an upload to experimental and ask if
> Lucas have time to do a mass-rebuild.
> 
> ~Niels
> 

I might do the upload "soon" (before the release), but lets keep the
mass-rebuild for post-freeze to avoid diverting peoples attention.

Thanks,
~Niels