[debhelper-devel] Bug#415396: Bug#415396: "dh_install --list-missing" should ignore manpages and other installed files

[Niels Thykier]

Michael Stapelberg:
> On Sat, Apr 8, 2017 at 7:54 AM, Niels Thykier <niels at thykier.net> wrote:
> 
>> Michael Stapelberg:
>>> On Mon, Apr 3, 2017 at 1:07 PM, Niels Thykier <niels at thykier.net> wrote:
>>>
>>>> [...]
>>>
>>>
>>> Thanks a lot!
>>>
>>> In turn, I created a branch in the freeradius packaging:
>>> https://anonscm.debian.org/cgit/pkg-freeradius/freeradius.git/log/?h=dh_
>> missing
>>>
>>
>> Thanks for trying it out. :)
>>
>>> Maybe I did the wrong changes (?), but when building, I get an error:
>>>
>>> [...]
>>>
>>> Can you reproduce the issue?
>>>
>>>
>>>
>>> [...]
>>
>> I think it is a bug in the freeradius changes.  In this commit:
>>
>> https://anonscm.debian.org/cgit/pkg-freeradius/
>> freeradius.git/commit/?h=dh_missing&id=58e693ff7dd6603598cb132d44c9e9
>> a547f099ed
>>
>> The dh_install call is replaced by dh_missing, but AFAICT that
>> dh_install is inside an override_dh_install, so dh_install is never called.
>>
> 
> Thanks, you are spot on. After re-adding the dh_install command, most of
> the errors vanish. Interestingly enough, this one remains:
> 
> [...]
> 
> I’ve added it to debian/freeradius.install and updated the branch.
>

Sounds good.  I am a little surprised that this gave issues now and not
before.  This smells like it might cause breakage with this change.

Speaking of stuff that might break: We had forgotten to pass --sourcedir
to dh_missing when dh_install calls it (fixed now).

> The only remaining issue as far as the freeradius packaging is concerned is
> dh_installdocs not yet reporting which files it installs — hence the build
> fails at
> https://anonscm.debian.org/cgit/pkg-freeradius/freeradius.git/commit/?h=dh_missing&id=afbb47b0f8646de9fc116d8f494608ef4cef6a90
> 

Ah.  I have deliberately omitted dh_installdocs as I thought people
would normally use dh_install for that kind of thing.  I think I will
keep that behaviour for a while...

Maybe with a documentation change for dh_installdocs that dh_install
might be better for documentation installed by upstream's build system.

> Either way, what you have in the dh_missing branch right now is already
> useful :).
> 
> 
>[...]

Thanks for the initial patches and the testing. :)

~Niels