[debhelper-devel] Bug#863887: debhelper: not running autoreconf anymore with compat level 9

[Iain Lane]

On Thu, Jun 01, 2017 at 03:23:19PM +0000, Gianfranco Costamagna wrote:
> Source: debhelper
> 
> Version: 10.4
> Severity: serious
> Justification: breaks compat level 9 autoreconf feature
> 
> 
> Hello, 
> as said, using debhelper 10.4 breaks my boinc builds,
> because dh_autoreconf is not run automatically anymore
> see this build log:
> https://launchpadlibrarian.net/322079774/buildlog_ubuntu-artful-amd64.boinc_7.7.0+dfsg~git20170601+r23738~r7~ubuntu17.10.1_BUILDING.txt.gz
> or this one:
> http://debomatic-amd64.debian.net/distribution#experimental/boinc/7.6.33+dfsg-12/buildlog
> 
> compat level used is 9,
> we have --with autoreconf
> and an override_dh_autoreconf call.
> 
> please, ask me more details if you want, I'll do my best to give them to you :)

It's caused by 80c955221e83327efb984845f59648678c729978.

boinc has an empty override_dh_autoreconf-indep target. Before this
commit we would run dh_autoreconf -Nboinc - because the else branch
inside the foreach loop would put the package name in @rest and -Nboinc
in @options which causes the calling code to call dh_autoreconf. Now,
because we skip the foreach loop entirely due to the empty target, the
parameters are never constructed and we simply skip over dh_autoreconf.

Unless you have a better idea, I think that commit should be reverted.
The loop is still required for empty -arch and -indep targets to
construct the -N options.

-- 
Iain Lane                                  [ iain at orangesquash.org.uk ]
Debian Developer                                   [ laney at debian.org ]
Ubuntu Developer                                   [ laney at ubuntu.com ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20170601/198e9f08/attachment-0003.sig>