[debhelper-devel] [debhelper] 02/02: Dh_Lib: Fail if open or close fails

Niels Thykier nthykier at moszumanska.debian.org
Sun Jun 25 18:21:25 UTC 2017


This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository debhelper.

commit f1281a00e497f7de50df581201283bc268eb64e6
Author: Niels Thykier <niels at thykier.net>
Date:   Sun Jun 25 18:20:54 2017 +0000

    Dh_Lib: Fail if open or close fails
    
    Signed-off-by: Niels Thykier <niels at thykier.net>
---
 Debian/Debhelper/Dh_Lib.pm | 4 ++--
 debian/changelog           | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Debian/Debhelper/Dh_Lib.pm b/Debian/Debhelper/Dh_Lib.pm
index 2403c8e..afb5643 100644
--- a/Debian/Debhelper/Dh_Lib.pm
+++ b/Debian/Debhelper/Dh_Lib.pm
@@ -1626,11 +1626,11 @@ sub log_installed_files {
 	return if $dh{NO_ACT};
 
 	my $log = generated_file($package, 'installed-by-' . basename($0));
-	open(my $fh, '>>', $log);
+	open(my $fh, '>>', $log) or error("open $log: $!");
 	for my $src (@patterns) {
 		print $fh "$src\n";
 	}
-	close($fh);
+	close($fh) or error("close $log: $!");
 
 	return 1;
 }
diff --git a/debian/changelog b/debian/changelog
index d21b069..213eee2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,8 @@ debhelper (10.5.1) UNRELEASED; urgency=medium
   * Dh_Lib.pm: Fix rounding error when computing how many processes
     to use.  This rounding error could cause dh-tools to use one more
     process than permitted by DEB_BUILD_OPTIONS.
+  * Dh_Lib.pm: Check return value of open+close when creating a log of
+    installed files.
 
  -- Niels Thykier <niels at thykier.net>  Sun, 25 Jun 2017 18:02:30 +0000
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debhelper/debhelper.git




More information about the debhelper-devel mailing list